-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create React Native ViewManager (+ Props + State) for HybridViews #500
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Ah, there might be some caveat about passing a callback as prop. These are implemented differently in react-native/fabric. They are just hold on the JS side and a general purpose native event emitter emits an event from native to js to call this callback and then its called from the JS side (if I am not mistaken). (A quick fix would be to box those, but I know how much you would hate that 😄 ) |
I thought the whole point of this was to have a point where we can access props as |
very much |
@mrousavy that might happen on the JS side already, not on the native side |
so worst case we need a PR that customizes/removes this behaviour from the JS side - maybe a third param to the getHostComponent thingy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good nice work @mrousavy
thanks |
Actually update props in the Swift/Kotlin view when they change in C++/JSI.
This makes Nitro Views ready for beta testing